Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info added #2022

Merged
merged 2 commits into from
Sep 18, 2022
Merged

Info added #2022

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a20b0c
info_added
KexinFeng Sep 16, 2022
821a647
info_added
KexinFeng Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions api/src/main/java/ai/djl/ndarray/index/full/NDIndexFullTake.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,24 @@ public static Optional<NDIndexFullTake> fromIndex(NDIndex index, Shape target) {
if (fullTake != null) {
// Don't support multiple takes
throw new UnsupportedOperationException(
"Only one take per get is currently supported");
"Only one take per get is currently supported.If this is triggered by"
+ " array NDIndex: get(NDIndex array), then you should be aware of"
+ " the following change: previously this was equivalent to"
+ " .get(new NDIndex().addPickDim(array)), but now equivalent to"
+ " .take(array). So please check if you want to restore the"
+ " previous behaviour ie .get(new NDIndex().addPickDim(array)). If"
+ " so do it explicitly.");
}
NDArray indexElem = ((NDIndexTake) el).getIndex();
if (!indexElem.getShape().isRankOne()) {
throw new UnsupportedOperationException(
"Only rank-1 indexing array is supported for take");
"Only rank-1 indexing array is supported for take. If this is triggered"
+ " by array NDIndex: get(NDIndex array), then you should be aware"
+ " of the following change: previously this was equivalent to"
+ " .get(new NDIndex().addPickDim(array)), but now equivalent to"
+ " .take(array). So please check if you want to restore the"
+ " previous behaviour ie .get(new NDIndex().addPickDim(array)). If"
+ " so do it explicitly.");
}
fullTake = new NDIndexFullTake(indexElem, axis);
} else {
Expand Down