Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vllm] leverage passthrough for generation_config engine argument #2727

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[vllm] leverage passthrough for generation_config engine argument #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions engines/python/setup/djl_python/properties_manager/vllm_rb_properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ class VllmRbProperties(Properties):
# Neuron vLLM properties
device: str = 'auto'
preloaded_model: Optional[Any] = None
generation_config: Optional[Any] = None
override_neuron_config: Optional[Dict] = None

# Non engine arg properties
Expand Down Expand Up @@ -237,7 +236,6 @@ def get_engine_args(self) -> EngineArgs:
# These neuron configs are not implemented in the vllm arg parser
if self.device == 'neuron':
setattr(engine_args, 'preloaded_model', self.preloaded_model)
setattr(engine_args, 'generation_config', self.generation_config)
setattr(engine_args, 'override_neuron_config',
self.override_neuron_config)
return engine_args
Expand Down
Loading