Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][lmi] fix issue where streaming response that finishes with empt… #2726

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[fix][lmi] fix issue where streaming response that finishes with empt… #2726

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion engines/python/src/main/java/ai/djl/python/engine/RollingBatch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ void addResponse(byte[] json, Map<String, String> properties) {
break;
}
}
if ((nextToken == null || nextToken.isEmpty()) && code == null) {
if ((nextToken == null || nextToken.isEmpty()) && !last) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For tool calling, the last token might be empty as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the test you put in caught this issue :)

// in non-streaming cases, we do not return content until generation is finished
return;
}
Expand Down
Loading