Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] install java for neuron conatiners #2723

Merged
merged 1 commit into from
Feb 6, 2025
Merged

[ci] install java for neuron conatiners #2723

merged 1 commit into from
Feb 6, 2025

Conversation

sindhuvahinis
Copy link
Contributor

Description

The reason for correctness test failure for neuron is, awscurl requires java and java is not installed in Deep Learning AMI Neuron.

So installing java, if it is not installed only if neuron devices exists. For GPU instances, nothing should happen. We are suppressing output and errors.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@sindhuvahinis sindhuvahinis requested review from zachgk and a team as code owners February 5, 2025 22:55
@sindhuvahinis sindhuvahinis merged commit e249be7 into master Feb 6, 2025
8 of 12 checks passed
@sindhuvahinis sindhuvahinis deleted the ci branch February 6, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants