Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[partition] relax tp and pp validations in partition script, use defa… #2709

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Feb 3, 2025

…ults in line with JIT UX

Description

This fixes the LMI-Dist quantization AOT test. tests.py::TestLmiDist1::test_llama2_tiny_autoawq.

In #2692, the change for is_mpi made it so that lmi-dist partition requires tp and pp to be set. To maintain backwards compatibility, this PR sets defaults for TP an PP in line with the JIT UX.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@siddvenk siddvenk requested review from zachgk and a team as code owners February 3, 2025 21:18
@@ -53,6 +53,12 @@ def __init__(self, args, **kwargs):
if 'addl_properties' in kwargs:
self.properties |= kwargs['addl_properties']

if "option.tensor_parallel_degree" not in self.properties:
self.properties["option.tensor_parallel_degree"] = str(
torch.cuda.device_count())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it break for neuron?

@siddvenk siddvenk merged commit 2104939 into deepjavalibrary:master Feb 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants