Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] convert lcnc test to use tp 2, till the issue is fixed in neuron… #2696

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sindhuvahinis
Copy link
Contributor

… sdk

Description

aws-neuron/aws-neuron-sdk#1100

This use case worked in 2.20 SDK, but it does not in 2.21. Looks like, this kind of issue had occurred in previous versions. aws-neuron/aws-neuron-sdk#1023. I have raised an issue in aws neuron sdk regarding this. And tp_degree 1 is a valid use case. Till they fix it, we could add tp_degree = 2 in our test cases.

And also, will update this in our release notes in the known issues section.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

@sindhuvahinis sindhuvahinis requested review from zachgk and a team as code owners January 30, 2025 22:18
@sindhuvahinis sindhuvahinis merged commit 1baf849 into deepjavalibrary:master Jan 31, 2025
9 checks passed
@sindhuvahinis sindhuvahinis deleted the tp1 branch January 31, 2025 02:29
sindhuvahinis added a commit to sindhuvahinis/djl-serving that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants