[python] return neuron cores instead of neuron devices #2695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Tranium or Inferentia devices, each neuron devices has multiple neuron cores, usualy 2 cores per device. Tensor parallel degree is specified in terms of neuron cores.
Here this method get_available_cores, is supposed to return the neuron cores, and we use this to set the default tp degree if one is not provided by the user.
In this PR, we are fixing this method to return neuron cores, previously it was return the neuron devices.
This PR, also fixes the CI which is failing for LCNC use case for AOT for tinyllama model. tp_degree is supposed to be 2, but we return 1 here, which causes the compilation to fail. This used to work in previous neuron sdk versions, even with tp_degree=1. So this seems to be regression in Neuron SDK 2.21.
Type of change
Please delete options that are not relevant.
Checklist:
pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B