Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] return neuron cores instead of neuron devices #2695

Closed
wants to merge 1 commit into from

Conversation

sindhuvahinis
Copy link
Contributor

Description

In Tranium or Inferentia devices, each neuron devices has multiple neuron cores, usualy 2 cores per device. Tensor parallel degree is specified in terms of neuron cores.

Here this method get_available_cores, is supposed to return the neuron cores, and we use this to set the default tp degree if one is not provided by the user.

In this PR, we are fixing this method to return neuron cores, previously it was return the neuron devices.

This PR, also fixes the CI which is failing for LCNC use case for AOT for tinyllama model. tp_degree is supposed to be 2, but we return 1 here, which causes the compilation to fail. This used to work in previous neuron sdk versions, even with tp_degree=1. So this seems to be regression in Neuron SDK 2.21.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • Please add the link of Integration Tests Executor run with related tests.
  • Have you manually built the docker image and verify the change?
  • Have you run related tests? Check how to set up the test environment here; One example would be pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant