[serving][python] Backport for pull #2173 to v0.28, support for non-2… #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pport for non-200 HTTP codes for non-streaming rolling batch requests
siddvenk
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…00 HTTP codes for non-streaming rolling batch requests
Description
This is an opt-in backport of a subset of the behavior added in pull request #2173 to v0.28.0-dlc, so that non-streaming rolling batch requests can return non-200 HTTP response codes on error. It's opt-in to avoid a breaking change for users using v0.28.0 who may require the old behavior.