Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] add max_logprobs vllm configuration to EngineArgs #2154

Merged
merged 1 commit into from
Jul 10, 2024
Merged

[python] add max_logprobs vllm configuration to EngineArgs #2154

merged 1 commit into from
Jul 10, 2024

Conversation

sindhuvahinis
Copy link
Contributor

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@sindhuvahinis sindhuvahinis requested review from zachgk, frankfliu and a team as code owners July 10, 2024 00:26
@sindhuvahinis sindhuvahinis merged commit 823563f into deepjavalibrary:master Jul 10, 2024
9 checks passed
@sindhuvahinis sindhuvahinis deleted the vllm branch July 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindhuvahinis @lanking520