Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][fix] don't use env vars for llm integ test as it causes issues w… #2068

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

siddvenk
Copy link
Contributor

@siddvenk siddvenk commented Jun 14, 2024

…ith later tests

Description

Moving the gpt2 test to serving.properties - using environment variables persists to following tests and causes multiple models to be loaded.

We already have a gpt2 config that matches the env vars, so just using that.

See this test run https://github.com/deepjavalibrary/djl-serving/actions/runs/9518222203/job/26238764686. The mpt test is loading gpt2 model first, causing oom when mpt test runs

@siddvenk siddvenk requested review from zachgk, frankfliu and a team as code owners June 14, 2024 19:42
@siddvenk siddvenk merged commit be8771b into deepjavalibrary:master Jun 14, 2024
7 checks passed
@siddvenk siddvenk deleted the integ-test branch June 14, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants