Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serving] Update python typing to support py38 #2034

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

tosterberg
Copy link
Contributor

Description

Updating typing nomenclature to support py38, python types are not sub-scriptable in py38 and we should instead use the typing class associated with the type. This will avoid build problems for users using ubuntu 20.04 and below.

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

@tosterberg tosterberg requested review from zachgk, frankfliu and a team as code owners June 6, 2024 23:05
@tosterberg tosterberg merged commit 8ad2395 into deepjavalibrary:master Jun 7, 2024
8 checks passed
@tosterberg tosterberg deleted the py38-compat branch June 7, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants