add TGI compat feature for rollingbatch #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
May 3, 2024
|
If the env name is finalized, every thing else, looks good to me. |
427a0f7 to
c69dea7
Compare
frankfliu
reviewed
May 4, 2024
| @@ -445,6 +451,8 @@ def __init__(self, **kwargs): | |||
| self.waiting_steps = kwargs.get("waiting_steps", None) | |||
| self.current_step = 0 | |||
| self.default_output_formatter = kwargs.get("output_formatter", None) | |||
| global TGI_COMPAT | |||
| TGI_COMPAT = kwargs.get("tgi_compat", "false").lower() == 'true' | |||
There was a problem hiding this comment.
Suggested change
| TGI_COMPAT = kwargs.get("tgi_compat", "false").lower() == 'true' | |
| self.tgi_compat = kwargs.get("tgi_compat", "false").lower() == 'true' |
There was a problem hiding this comment.
There is no way to pass this value back to the serializer. Unless we make them to be part of the Request class
frankfliu
approved these changes
May 6, 2024
lanking520
pushed a commit
to lanking520/djl-serving
that referenced
this pull request
May 7, 2024
lanking520
pushed a commit
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TGI compatibility support