-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Updating lmi-dist ci tests for rubikon-engine #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also remove the speculative decoding test in vLLM?
fabc9d0
to
1ff1005
Compare
1ff1005
to
d339ef6
Compare
d339ef6
to
be31ff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok for our CI tests to use HF model ids directly rather than s3 links?
Other than that, LGTM.
There is a problem with HF id. Firstly it is not very stable. Secondly, sometimes the download speed is very slow and cause timeout (flaky tests) |
@maaquib could you also just replace the lmi-dist handler with the new one in this PR, so we can just cover in CI testing? |
fba9e9d
to
dac46f0
Compare
could you also add tests for vLLM as well, just to serve as baseline? |
a23f83c
to
a890bd6
Compare
Added gemma and starcoder2 to vllm |
d33c72e
to
f69e891
Compare
f69e891
to
f7dff75
Compare
f7dff75
to
c63330f
Compare
5a1cbbf
to
5adc189
Compare
5adc189
to
45dca51
Compare
Description
Following changes have been made