Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove a bit of unused code #1536

Merged
merged 1 commit into from
Feb 12, 2024
Merged

remove a bit of unused code #1536

merged 1 commit into from
Feb 12, 2024

Conversation

ydm-amazon
Copy link
Contributor

@ydm-amazon ydm-amazon commented Feb 12, 2024 •
edited
Loading

Please let me know if it is alright to remove this code now that it's not needed

This PR removes 2 things in hf_properties:

  1. the awq value in the HFQuantizeMethods enum
  2. LMI_DIST_ADV_MODEL, which has been moved to huggingface handler

@ydm-amazon ydm-amazon marked this pull request as ready for review February 12, 2024 17:44
@ydm-amazon ydm-amazon requested review from zachgk, frankfliu and a team as code owners February 12, 2024 17:44
@ydm-amazon ydm-amazon merged commit 3b91d39 into deepjavalibrary:master Feb 12, 2024
6 of 8 checks passed
@ydm-amazon ydm-amazon mentioned this pull request Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanking520 lanking520 lanking520 approved these changes

@zachgk zachgk Awaiting requested review from zachgk zachgk is a code owner

@frankfliu frankfliu Awaiting requested review from frankfliu

@sindhuvahinis sindhuvahinis Awaiting requested review from sindhuvahinis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydm-amazon @lanking520