Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: DH-18471 update_by min/max functions to return original-typed output columns #6629

Merged
merged 2 commits into from
Feb 7, 2025
Merged

fix!: DH-18471 update_by min/max functions to return original-typed output columns #6629

merged 2 commits into from
Feb 7, 2025

Conversation

lbooker42
Copy link
Contributor

Add'l work performed:

  • Added char support to CumMin/CumMax and expanded tests
  • Added PartionedTable proxy tests

@lbooker42 lbooker42 self-assigned this Feb 6, 2025
@lbooker42 lbooker42 added bug Something isn't working NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Feb 6, 2025
@lbooker42 lbooker42 added this to the 0.38.0 milestone Feb 6, 2025
lbooker42
lbooker42 commented Feb 6, 2025
View reviewed changes
Copy link
Contributor Author

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review

...able/src/main/java/io/deephaven/engine/table/impl/partitioned/PartitionedTableProxyImpl.java Outdated Show resolved Hide resolved
@lbooker42
Copy link
Contributor Author

Achieved 100% coverage for operators with new tests:
image
image

@lbooker42 lbooker42 marked this pull request as ready for review February 6, 2025 19:02
@lbooker42 lbooker42 marked this pull request as draft February 6, 2025 22:11
@lbooker42 lbooker42 force-pushed the nightly/DH-18471-lab-rollingminmax-fix branch from 8f1e267 to 849bf20 Compare February 6, 2025 23:55
@lbooker42 lbooker42 marked this pull request as ready for review February 7, 2025 00:12
@lbooker42 lbooker42 merged commit 1feacf4 into deephaven:main Feb 7, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cpwright cpwright cpwright approved these changes

Assignees

@lbooker42 lbooker42

Labels
bug Something isn't working NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
0.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lbooker42 @cpwright