Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: For iceberg test failures with unclosed ResolvingFileIO instance #6217

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: For iceberg test failures with unclosed ResolvingFileIO instance #6217

merged 1 commit into from
Oct 18, 2024

Conversation

malhotrashivam
Copy link
Contributor

@malhotrashivam malhotrashivam commented Oct 18, 2024 •
edited
Loading

Fix for nightly job failures which look like

[Finalizer] WARN org.apache.iceberg.io.ResolvingFileIO - Unclosed ResolvingFileIO instance created by:	
	org.apache.iceberg.io.ResolvingFileIO.<init>(ResolvingFileIO.java:77)	
	io.deephaven.iceberg.TestCatalog.IcebergTestTable.io(IcebergTestTable.java:223)	
	io.deephaven.iceberg.util.IcebergCatalogAdapter.readTableInternal(IcebergCatalogAdapter.java:812)	
	io.deephaven.iceberg.util.IcebergCatalogAdapter.readTable(IcebergCatalogAdapter.java:656)	
	io.deephaven.iceberg.util.IcebergToolsTest.testReorderedPartitioningColumn(IcebergToolsTest.java:479)

@malhotrashivam malhotrashivam added this to the 0.37.0 milestone Oct 18, 2024
@malhotrashivam malhotrashivam self-assigned this Oct 18, 2024
lbooker42
lbooker42 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@lbooker42 lbooker42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good change.

@malhotrashivam malhotrashivam requested a review from rcaudy October 18, 2024 21:45
@malhotrashivam malhotrashivam changed the title fix: For iceberg test failure for unclosed ResolvingFileIO instance fix: For iceberg test failures with unclosed ResolvingFileIO instance Oct 18, 2024
@malhotrashivam malhotrashivam merged commit 8f02178 into deephaven:main Oct 18, 2024
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy approved these changes

@lbooker42 lbooker42 lbooker42 approved these changes

@devinrsmith devinrsmith Awaiting requested review from devinrsmith

Assignees

@malhotrashivam malhotrashivam

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. test
Projects
None yet
Milestone
0.37.0
Development

Successfully merging this pull request may close these issues.
3 participants
@malhotrashivam @lbooker42 @rcaudy