feat: Barrage Refactor Read/Write Chunk Factories #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a6ad4c9 to
c4e970d
Compare
c4e970d to
28b25d1
Compare
rcaudy
reviewed
Sep 16, 2024
engine/table/src/main/java/io/deephaven/engine/table/impl/QueryTable.java
Outdated
Show resolved
Hide resolved
engine/table/src/main/java/io/deephaven/engine/table/impl/sources/ReinterpretUtils.java
Show resolved
Hide resolved
| @@ -18,7 +20,56 @@ | |||
| /** | |||
| * Consumes Flight/Barrage streams and transforms them into WritableChunks. | |||
| */ | |||
| public interface ChunkReader { | |||
| public interface ChunkReader<ReadChunkType extends WritableChunk<Values>> { | |||
There was a problem hiding this comment.
We wondered if you could make the bound looser, e.g. PoolableChunk or SafeCloseable. Looks like maybe not? Should PoolableChunk be a Chunk (it's not right now)?
There was a problem hiding this comment.
We need these to return the Chunks to support usages such as LongChunkReader#transformTo. Since ownership is also being passed, it is best to advertise that they're WritableChunks.
extensions/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/ChunkReader.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Outdated
Show resolved
Hide resolved
...s/barrage/src/main/java/io/deephaven/extensions/barrage/chunk/DefaultChunkWriterFactory.java
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| private static long factorForTimeUnit(final TimeUnit unit) { |
flakiness (#9948)"
|
I think this should fix #6201 - at one point I believe you had nbauernfeind@b18d660 in this branch, can you bring it back in so we can verify the fix, remove the TODO, and mark that issue as fixed in the description? |
rtt for arrow Duration type Fix FMRTT#testLongColumnWithFactor rtt for Time rtt for Date incomplete Interval
…Time64 to ColumnSource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul of type mapping from arrow to deephaven columns. We can now coerce from many kinds of types, enabling widening / truncating and conversion between types. For example uint64_t is now mapped to BigInteger by default, but can be explicitly mapped to
long.class(may overflow).To set an explicit mapping set the attribute "deephaven:type" to the canonical name of the class.
Fixes #58 (custom type serialization / deserialization).
Fixes #936 (ColumnConversionModes is being replaced with easy to integrate custom serialization).
Fixes #2984 (refactoring has good interface documentation).
Fixes #3403 (by supporting a variety of mappings, these now must match client wiring).
Fixes #5258 (snapshot/subscribe methods with default w2w options).
Fixes #5453 (support other Timestamp arrow wire encodings).
Fixes #5864 (support for uint64_t).
Fixes #6114 (supports ObjectVector properly).
nightlies: https://github.com/nbauernfeind/deephaven-core/actions/runs/13208235220/