Revert one of the checks added in BooleanSparseArraySource

deephaven · Feb 5, 2025 · 71817cb · 71817cb
1 parent e569c5d
commit 71817cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/.../table/src/main/java/io/deephaven/engine/table/impl/sources/BooleanSparseArraySource.java b/.../table/src/main/java/io/deephaven/engine/table/impl/sources/BooleanSparseArraySource.java
@@ -106,7 +106,7 @@ public void setNull(long key) {
             return;
         }
         final int indexWithinBlock = (int) (key & INDEX_MASK);
-        if (BooleanUtils.isNull(blocks2[indexWithinBlock])) {
+        if (blocks2[indexWithinBlock] == NULL_BOOLEAN_AS_BYTE) {
             return;
         }
 

diff --git a/replication/static/src/main/java/io/deephaven/replicators/ReplicateSourcesAndChunks.java b/replication/static/src/main/java/io/deephaven/replicators/ReplicateSourcesAndChunks.java
@@ -1163,9 +1163,7 @@ private static void replicateBooleanSparseArraySource() throws IOException {
         lines = simpleFixup(lines, "nullByRanges",
                 "block\\[indexWithinBlock\\] != NULL_BOOLEAN", "!BooleanUtils.isNull(block[indexWithinBlock])",
                 "NULL_BOOLEAN", "NULL_BOOLEAN_AS_BYTE");
-        lines = simpleFixup(lines, "setNull",
-                "blocks2\\[indexWithinBlock\\] == NULL_BOOLEAN", "BooleanUtils.isNull(blocks2[indexWithinBlock])",
-                "NULL_BOOLEAN", "NULL_BOOLEAN_AS_BYTE");
+        lines = simpleFixup(lines, "setNull", "NULL_BOOLEAN", "NULL_BOOLEAN_AS_BYTE");
 
         lines = replaceRegion(lines, "copyFromTypedArray", Arrays.asList(
                 "                    for (int jj = 0; jj < length; ++jj) {",
-Original file line number
+Diff line change
@@ Expand Up / @@ -106,7 +106,7 @@ public void setNull(long key) { @@
                 return;
             }
             final int indexWithinBlock = (int) (key & INDEX_MASK);
-            if (BooleanUtils.isNull(blocks2[indexWithinBlock])) {
+            if (blocks2[indexWithinBlock] == NULL_BOOLEAN_AS_BYTE) {
                 return;
             }
@@ Expand Down @@