Skip to content

Commit

Permalink
Manage kube-delivery image from training-operator and update it (kube…
Browse files Browse the repository at this point in the history
…flow#1909)

* Create Dockerfile

* Update Dockerfile

* Create deliver-kubectl.sh

* Update publish-core-images.yaml

* Using kubeflow kubectl-delivery

* Delete scripts/kubectl-delivery/deliver-kubectl.sh

* Refactor Dockerfile

* Create Dockerfile

* Update Dockerfile

* Create deliver-kubectl.sh

* Update publish-core-images.yaml

* Using kubeflow kubectl-delivery

* Delete scripts/kubectl-delivery/deliver-kubectl.sh

* Refactor Dockerfile

---------

Co-authored-by: ULBRICR <robert.ulbrich@mercedes-benz.com>
  • Loading branch information
rpemsel and robert-ulbrich-mercedes-benz authored Sep 8, 2023
1 parent 12eefea commit afba76b
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/publish-core-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,5 @@ jobs:
include:
- component-name: training-operator
dockerfile: build/images/training-operator/Dockerfile
- component-name: kubectl-delivery
dockerfile: build/images/kubectl-delivery/Dockerfile
16 changes: 16 additions & 0 deletions build/images/kubectl-delivery/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
FROM alpine:3.17 AS build

# Install kubectl.
ENV K8S_VERSION v1.27.5

RUN apk add --no-cache wget
RUN wget -q https://storage.googleapis.com/kubernetes-release/release/${K8S_VERSION}/bin/linux/amd64/kubectl
RUN chmod +x ./kubectl
RUN mv ./kubectl /bin/kubectl

FROM alpine:3.17
COPY --from=build /bin/kubectl /bin/kubectl
RUN apk add --no-cache bash

ENTRYPOINT ["/bin/sh", "-c"]
CMD ["cp /bin/kubectl /opt/kube/kubectl"]
2 changes: 1 addition & 1 deletion pkg/config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ const (
// PyTorchInitContainerMaxTriesDefault is the default number of tries for the pytorch init container.
PyTorchInitContainerMaxTriesDefault = 100
// MPIKubectlDeliveryImageDefault is the default image for launcher pod in MPIJob init container.
MPIKubectlDeliveryImageDefault = "mpioperator/kubectl-delivery:latest"
MPIKubectlDeliveryImageDefault = "kubeflow/kubectl-delivery:latest"
)

0 comments on commit afba76b

Please sign in to comment.