Determine eloquent attribute type from casts #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kburton-dev
commented
Mar 18, 2024
| @@ -89,15 +86,53 @@ private function getBaseAttributeType(Model $model, string $key, array $value) | |||
| default => new UnknownType("unimplemented DB column type [$type[0]]"), | |||
| }; | |||
|
|
|||
| if ($value['cast'] && function_exists('enum_exists') && enum_exists($value['cast'])) { | |||
| if (! isset($value['cast']::cases()[0]->value)) { | |||
There was a problem hiding this comment.
I think this check is for backed enums, but might not be necessary as Laravel supports both.
kburton-dev
commented
Mar 18, 2024
| @@ -89,15 +86,53 @@ private function getBaseAttributeType(Model $model, string $key, array $value) | |||
| default => new UnknownType("unimplemented DB column type [$type[0]]"), | |||
| }; | |||
|
|
|||
| if ($value['cast'] && function_exists('enum_exists') && enum_exists($value['cast'])) { | |||
There was a problem hiding this comment.
With PHP 8.1 being the min version now, function_exists('enum_exists') check is not required anymore
|
@kburton-dev what a great work! Thank you so much for your time, I appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this discussion, the schema types differ slightly when generating the OpenAPI json, if using different databases, such as MySQL and SQLite.
This is to be expected if the idea is to rely on the DB schema alone to generate the API schema from Eloquent models.
This PR aims to add support for the various model casts that Laravel provides.