Resolve ternary types properly

[kburton-dev]

I noticed that some ternary types in my JSON resources were not being resolved properly. For example, a resource could look like this

public function toArray(): array
{
    return [
        'foo' => $this->foo ? FooResource::make($this->foo) : null
    ];
}

Would get a property type such as foo: { type: string }, losing a lot of information about the nested resource.

I hacked together a quick fix for this. I hope I did so in a suitable fashion.

[WildEgo]

Could you check how it generates $this->when? I'm not sure how scramble handles this

[kburton-dev]

Could you check how it generates $this->when? I'm not sure how scramble handles this

It works fine using ->when() ✅

But then I need to pass a function fn () => null as the third argument. With only null (the default) the property is omitted in the response.

Using a ternary is pretty common, so I think it should be handled well.

[romalytvynenko]

Looking good! Small fix is needed to avoid duplicated sub-types in resulting Union and I will happily merge it.

Thanks.

UPD: Also, please update the test to test only Scope class. The only thing that we want to test here is that ternary expression results in Union type when inferring the type, this is not related to API resources.