Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint warnings #300

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix lint warnings #300

wants to merge 3 commits into from

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented Feb 8, 2025

after setting up the golangci tool, attemp to reduce lint warnings

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13217030395

Details

  • 40 of 49 (81.63%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.496%
Changes Missing Coverage Covered Lines Changed/Added Lines %
dkg/pedersen/dkg.go 0 2 0.0%
mino/minogrpc/server.go 0 2 0.0%
mino/minogrpc/session/addr.go 7 12 58.33%
Totals Coverage Status
Change from base Build 13214499915: 0.0%
Covered Lines: 16859
Relevant Lines: 17841
💛 - Coveralls

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ineiti
Copy link
Member

ineiti commented Feb 11, 2025

Where are the LLMs when they could be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbsv @coveralls @ineiti