Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix protobuf generation #298

Merged
merged 5 commits into from
Feb 8, 2025
Merged

fix protobuf generation #298

merged 5 commits into from
Feb 8, 2025

Conversation

jbsv
Copy link
Contributor

@jbsv jbsv commented Feb 8, 2025

Fixes protobuf generation

@coveralls
Copy link

coveralls commented Feb 8, 2025

Pull Request Test Coverage Report for Build 13214453703

Details

  • 239 of 335 (71.34%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.8%) to 94.485%

Changes Missing Coverage Covered Lines Changed/Added Lines %
mino/minogrpc/ptypes/overlay_grpc.pb.go 106 142 74.65%
mino/minogrpc/ptypes/overlay.pb.go 133 193 68.91%
Files with Coverage Reduction New Missed Lines %
cli/node/daemon.go 4 93.37%
Totals Coverage Status
Change from base Build 11276306362: -2.8%
Covered Lines: 16840
Relevant Lines: 17823

💛 - Coveralls

@jbsv jbsv merged commit 407063e into main Feb 8, 2025
7 of 8 checks passed
@jbsv jbsv deleted the minows2 branch February 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants