Adding MinoWS module #292
Closed
Adding MinoWS module #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Zach Xion XioZ@users.noreply.github.com This commit implements a new Mino handler using libp2p with websockets. Contrary to MinoGRPC it doesn't use any locks and uses a 1-level tree to handle messages. It is at least as performant as the MinoGRPC implementation, and works with d-voting.
Co-authored-by: Zach Xion XioZ@users.noreply.github.com
- Adding new version of libp2p - Re-enabling failing test and remove goverall - Use peer.ID.Validate - Don't export Packet and Forward - Merging participant and orchestrator
- There was a race-condition in the echoHandler which made it fail on fast machines. - Changed the tests to wait for the accurate number of messages, instead of waiting for 2 seconds. - Also fixed an incompatibility in the Makefile wrt the github runners. - Added a test to the fuzzy tests in the Makefile
Fixing race condition and adding fuzzy test
Check the source repo of the PR and not the destination repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding minows module to simplify the network stack and avoid locking issues.
This also opens the way to use other protocols supported by libp2p.