Skipchain leader only #25
Conversation
| // and that needs to be processed by the node. It provides some useful | ||
| // information about the network layer. | ||
| type Request struct { | ||
| Address Address |
There was a problem hiding this comment.
I would comment what address this corresponds to
| @@ -59,7 +68,7 @@ type RPC interface { | |||
| type Handler interface { | |||
| // Process handles a single request by producing the response according to | |||
| // the request message. | |||
| Process(req proto.Message) (resp proto.Message, err error) | |||
| Process(req Request) (resp proto.Message, err error) | |||
There was a problem hiding this comment.
following that, shouldn't we also update Receiver.Recv from Recv(context.Context) (Address, proto.Message, error) to Recv(context.Context) (Request, error) ?
There was a problem hiding this comment.
Also, if this is not likely that we add more things to Request, I would find it better to try keeping this interface simple and not use a new struct: Process(req Request, addr Address) (resp proto.Message, err error), as you are already doing with Receiver.Recv
There was a problem hiding this comment.
As discussed, I think it will be useful later.
f1414fb to
11b0cc6
Compare
| type Validator interface { | ||
| // PayloadProcessor is the interface to implement to validate the generic | ||
| // payload stored in the block. | ||
| type PayloadProcessor interface { |
There was a problem hiding this comment.
makes me think: we should also add the definition of "payload" to our terminologies.
blockchain/viewchange/mod.go
Outdated
| // propose a block as the leader. It is also responsible for verifying the | ||
| // integrity of the players of the chain. | ||
| type ViewChange interface { | ||
| // Wait returns a non-nil error when the node is allowed to make the |
There was a problem hiding this comment.
- You return an error when you are allowed to make a proposal?
- I would use the same word in the comment and the code: in the comment you speak about "proposal" and in the code its "block".
- It feels strange to suddenly speak about a "node". I would be a bit more precise by saying maybe "...returns a non-nil error when the node running the code is..."
There was a problem hiding this comment.
Oops, no it's a nil error when allowed. I changed node by player to be more consistent.
| @@ -30,6 +30,25 @@ func ApplyFilters(filters []FilterUpdater) *Filter { | |||
| // FilterUpdater is a function to update the filters. | |||
| type FilterUpdater func(*Filter) | |||
|
|
|||
| // RotateFilter is a filter to rotate the indices. When n is above zero, it will | |||
There was a problem hiding this comment.
so we should update the comment at line 12: "This list is always sorted."
There was a problem hiding this comment.
There's already the comment ;)
0981684 to
77ee16f
Compare
Skipchain leader only
Check the source repo of the PR and not the destination repo
This adds information to the Handler.Process so that network layer info are accessible. It then uses that information to force a skipchain block to be proposed by the leader only.