Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor GUI improvements and bugfixes. #495

Merged
merged 17 commits into from
Nov 2, 2024

Conversation

jholdstock
Copy link
Member

@jholdstock jholdstock commented Nov 1, 2024

This PR includes many small improvements to the GUI and some bugfixes. Some examples provided below.

Also included is an upgrade from bootstrap 4.5 to 4.6.2. Nothing major changes in the new version, just some improved compatibility/consistency between browsers.

Needs squashing before merge.

Deployed to testnet-vsp.jholdstock.uk and I'm happy to provide reviewers with the admin password.


Fixed an issue where long pages (such as ticket search result) would allow the viewer to scroll beyond the footer

Example of before

Fixed footer stretching to full widescreen size rather than staying inside bounds of bootstrap container

Before
After

More consistent style for inputs (password prompt, ticket search input)

Before
After

Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for splitting it up into easily digestible commits to make the review much easier.

background-color: #202a52;
}

@media (max-width: 768px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering why this was removed in an earlier commit with no replacement!

@jholdstock jholdstock merged commit 363fdcb into decred:master Nov 2, 2024
2 checks passed
jholdstock added a commit to jholdstock/vspd that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants