-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor GUI improvements and bugfixes. #495
Conversation
8c50a43
to
ffd357b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for splitting it up into easily digestible commits to make the review much easier.
background-color: #202a52; | ||
} | ||
|
||
@media (max-width: 768px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering why this was removed in an earlier commit with no replacement!
This PR includes many small improvements to the GUI and some bugfixes. Some examples provided below.
Also included is an upgrade from bootstrap 4.5 to 4.6.2. Nothing major changes in the new version, just some improved compatibility/consistency between browsers.
Needs squashing before merge.
Deployed to testnet-vsp.jholdstock.uk and I'm happy to provide reviewers with the admin password.
Fixed an issue where long pages (such as ticket search result) would allow the viewer to scroll beyond the footer
Example of before
Fixed footer stretching to full widescreen size rather than staying inside bounds of bootstrap container
Before
After
More consistent style for inputs (password prompt, ticket search input)
Before
After