multi: Consolidate waitgroup logic. #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
reviewed
Oct 25, 2023
a3eb3a0 to
03846ae
Compare
jrick
approved these changes
Oct 25, 2023
jholdstock
approved these changes
Oct 26, 2023
This switches the various subsystems over to use a new pattern that consolidates the waitgroup logic in a single location. This pattern is easier to reason about and less error prone since it's trivial to see at a glance that the calls to Done are happening as intended versus having to chase them down all over the code.
03846ae to
4e3263c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3199.
This switches the various subsystems over to use a new pattern that consolidates the waitgroup logic in a single location.
This pattern is easier to reason about and less error prone since it's trivial to see at a glance that the calls to Done are happening as intended versus having to chase them down all over the code.