blockchain: Remove several unused error returns. #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the error return from the nextThresholdState method since it is no longer used due to previous updates.
This removes the error return from the stateLastChanged method since it is no longer used due to previous updates.
This removes the error return from the deploymentState method since it is no longer used due to previous updates.
This removes the error return from the maxBlockSize method since it is no longer used due to previous updates.
This removes the error return from the calcNextRequiredStakeDifficultyV1 method since it is no longer used due to previous updates.
This removes the error return from the calcNextRequiredStakeDifficulty method since it is no longer used due to previous updates.
jholdstock
approved these changes
May 4, 2023
JoeGruffins
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists of a series of commits to remove unused error returns from several internal
blockchainmethods one at a time for ease of review.The error return is removed from the following methods:
blockchain.nextThresholdStateblockchain.stateLastChangedblockchain.deploymentStateblockchain.maxBlockSizeblockchain.calcNextRequiredStakeDifficultyV1calcNextRequiredStakeDifficulty