rpcserver: Consolidate mock mining addr. #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b5267b to
cc32664
Compare
jholdstock
approved these changes
Apr 25, 2023
dajohi
approved these changes
Apr 26, 2023
This modifies the RPC server tests to create a mining address as a part of the default mining state and use that state throughout. It also removes the separate mock mining address override field since the same thing can be accomplished via the mock mining state now. This has the effect of consolidating the logic and simplifying its usage.
cc32664 to
0250007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is rebased on #3104.
This modifies the RPC server tests to create a mining address as a part of the default mining state and use that state throughout. It also removes the separate mock mining address override field since the same thing can be accomplished via the mock mining state now.
This has the effect of consolidating the logic and simplifying its usage.