rpcserver: Decouple RPC agenda info status strings. #3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
approved these changes
Mar 3, 2023
Similar to the case that previously existed for getblockchainfo, currently, the getvoteinfo RPC implementation directly returns the internal threshold state strings defined in blockchain. This is not ideal since it means that any changes to the internal implementation could inadvertently change the RPC results without being noticed. Further, the blockchain package is now internal which means external callers don't have access to those constants. Consequently, this makes the same change to getvoteinfo as was previously made to getblockchaininfo to decouple the agenda status strings by converting the internal blockchain threshold state to use the agenda status string constants defined in the rpc/jsonrpc/types module.
e75364d to
83b7f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the case that previously existed for
getblockchainfo, currently, thegetvoteinfoRPC implementation directly returns the internal threshold state strings defined inblockchain. This is not ideal since it means that any changes to the internal implementation could inadvertently change the RPC results without being noticed.Further, the
blockchainpackage is now internal which means external callers don't have access to those constants.Consequently, this makes the same change to
getvoteinfoas was previously made togetblockchaininfoto decouple the agenda status strings by converting the internalblockchainthreshold state to use the agenda status string constants defined in therpc/jsonrpc/typesmodule.