multi: Remove rpctest package #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great 👍 |
dnldd
approved these changes
Nov 30, 2022
davecgh
reviewed
Nov 30, 2022
davecgh
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Very nice work on this and getting the RPC testing framework all split out and updated to improve some of its warts.
I ran the relevant affected tests on both a Linux and Windows environment:
$ go test ./internal/rpcserver
ok github.com/decred/dcrd/internal/rpcserver 5.628s
$ go test -tags rpctest ./internal/integration/rpctests
ok github.com/decred/dcrd/internal/integration/rpctests 53.963s
I also confirmed that it is in fact building the most recent dcrd code before running the tests by both manually examining the built binary in the temp dir and also by intentionally breaking an RPC handler:
$ go test -tags rpctest -run=TestRpcServer ./internal/integration/rpctests
--- FAIL: TestRpcServer (2.80s)
rpcserver_test.go:41: Block hashes do not match. Returned hash 0000000000000000000000000000000000000000000000000000000000000000, wanted hash 008e857ca0493162baf6c7f9261a253bec65cda771d75c09ed3dc309da66a7ab
FAIL
FAIL github.com/decred/dcrd/internal/integration/rpctests 2.920s
FAIL
I'm going to go ahead and approve, but as mentioned, it does still need a go mod tidy before merge.
This moves all tests that rely on the rpctest package to their own package (internal/integration/rpctests) in preparation of switching to the recently introduced dcrdtest package.
This switches the tests in the rpctests package to use the recently introduced dcrtest/dcrdtest package. Given the rpctests package is inside the main dcrd module, the main dcrd module version is built for use in tests by default.
This removes the now unused rpctest package.
9cf3ad2 to
e9b9a4a
Compare
|
Tidied and rebased against latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the existing tests that rely on the existing
rpctestpackage to a new internalintegration/rpctestspackage, switches them to use the recently introduceddcrtest/dcrdtestpackage and finally removes therpctestpackage from this repository.