server: Remove unnecessary vote ntfn check. #2942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajohi
approved these changes
May 10, 2022
rstaudt2
approved these changes
May 11, 2022
This removes the check for whether or not the block height is after the height of the final checkpoint when deciding whether to send a vote notification since it is no longer necessary or has any effect. The reason it no longer has any effect is because there is a check prior to it that ensures the the chain is considered current and the more recent headers-first syncing means the chain will not be considered current until the block associated with the best known header is reached which is always ahead of any checkpoint.
a99216d to
bc06c8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the check for whether or not the block height is after the height of the final checkpoint when deciding whether to send a vote notification since it is no longer necessary or has any effect.
The reason it no longer has any effect is because there is a check prior to it that ensures the the chain is considered current and the more recent headers-first syncing means the chain will not be considered current until the block associated with the best known header is reached which is always ahead of any checkpoint.