Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing VTEX catalog filters URL on categories and search #41

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add missing VTEX catalog filters URL on categories and search #41

merged 2 commits into from
Sep 13, 2023

Conversation

matheusgr
Copy link
Contributor

@matheusgr matheusgr commented Sep 11, 2023 •
edited
Loading

Fix legacy filters to:

  • keep current query on URL
  • ignore empty mappings (ex.: ,c should be only 1 mapping)
  • allow root facet to be removing (thus returning to home)

Tests:

@matheusgr matheusgr force-pushed the fix_filter_on_legacy_search_and_categories branch from fea9bad to cb04b87 Compare September 13, 2023 13:24
@matheusgr matheusgr added the bug Something isn't working label Sep 13, 2023
@matheusgr matheusgr changed the title Fix vtex legacy filters on categories/search. Fix VTEX catalog filters on categories/search. Sep 13, 2023
@matheusgr matheusgr changed the title Fix VTEX catalog filters on categories/search. Fix VTEX catalog filters on categories/search Sep 13, 2023
@matheusgr matheusgr changed the title Fix VTEX catalog filters on categories/search Add missing VTEX catalog filters URL on categories and search Sep 13, 2023
@matheusgr matheusgr merged commit b6a7dca into main Sep 13, 2023
@matheusgr matheusgr deleted the fix_filter_on_legacy_search_and_categories branch September 13, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlgimenes tlgimenes tlgimenes approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusgr @tlgimenes