Improve srcSet flexibility in the Image component #1050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
The
Image
component serves as a wrapper that optimizes image URLs for each e-commerce platform while leveraging the optimized Deco CDN. However, the currentsrcSet
generation is limited because it only considers two factors, preventing the generation of intermediate image sizes.Since modifying the existing
srcSet
logic could introduce breaking changes across all stores, a more flexible approach would be to allow an optionalsrcSet
prop, enabling customization without altering the default behavior.Proposed Solution:
Introduce an optional
srcSet
prop to theImage
component, allowing developers to define custom breakpoints while maintaining backward compatibility.