[controller] Fix sds-health-watcher controller's incorrect used nodes count #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
b420d76 to
1db5f25
Compare
AleksZimin
approved these changes
Sep 5, 2024
ViktorKram
added a commit
that referenced
this pull request
Sep 17, 2024
… count (#92) Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
astef
pushed a commit
that referenced
this pull request
Feb 13, 2025
… count (#92) Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the way the controller count the nodes used by LVMVolumeGroup resources
Why do we need it, and what problem does it solve?
It prevents the case when the controller gets some nodes without a LVMVolumeGroup resource, but still used to count as there should be a sds-node-configurator pod on the node.
What is the expected result?
The controller operates only with LVMVolumeGroup used nodes.
Checklist