Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[controller] Data wipe unit tests #128

Merged
merged 31 commits into from
Feb 28, 2025
Merged

[controller] Data wipe unit tests #128

merged 31 commits into from
Feb 28, 2025

Conversation

asergunov
Copy link
Contributor

Description

  • Test for VolumeCleanup function
  • BlockDevice interface to mock it in tests of VolumeCleanup
  • Test for BlockDevice
  • SysCall interface to mock it in BlockDevice tests

Why do we need it, and what problem does it solve?

Another place to describe expected behavior so we will know if it's still works as expexted

What is the expected result?

Test coverage

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@asergunov asergunov changed the title Data wipe unit tests [Draft] Data wipe unit tests Feb 21, 2025
@asergunov asergunov marked this pull request as draft February 21, 2025 12:36
@asergunov asergunov changed the title [Draft] Data wipe unit tests Data wipe unit tests Feb 21, 2025
@asergunov asergunov changed the base branch from main to add-data-wipe February 21, 2025 12:37
@asergunov asergunov added the enhancement New feature or request label Feb 21, 2025
kneumoin
kneumoin reviewed Feb 21, 2025
View reviewed changes
Base automatically changed from add-data-wipe to main February 25, 2025 08:49
@asergunov asergunov self-assigned this Feb 25, 2025
@asergunov
preparing to tests
284f78e 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Tests for device and cleanup are added
260f8d3 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Make test errors fatal
a66b17c 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Use filepath.Join
e765f07 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
ce tests are added
b5e35d2 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
fix error
e290a0f 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Check feature enable in tests
67b3d13 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
lint errors
d6884b8 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Don't expect any calls if cleanup is not enabled
20fadfc 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
ee lint fix
18554a3 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
lint for ee
677fde6 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
ee context
575e690 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
don't expect discard calls if feature is not enabled
b18ccb8 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
replace syscall package by golang.org/x/sys/unix
1a84dac 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
anonymous struct
8f4035c 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
use %w in fmt.Errorf
b953241 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
== 0 for uint64
7fa44d2 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
cleanup
dd81476 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
separate package for tests and mock
4f18f14 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
typed mock
58a73ed 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
ginkgo cleanup tests
ec18ad6 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
WIP
931a893 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
block device open failure test
ba1cf31 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Error checks
eea23de 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Move close expectation
2eecdae 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Handle closing errors
0c32388 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
lint
81cdf62 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Remove test run we don't need
1dc7e72 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Cleanup
7eac719 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
Make se pass
bda11a5 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov
cleanup
b27d51e 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
@asergunov asergunov force-pushed the data-wipe-unit-tests branch from 2144bfc to b27d51e Compare February 25, 2025 09:14
@asergunov asergunov marked this pull request as ready for review February 25, 2025 10:05
@AleksZimin AleksZimin changed the title Data wipe unit tests [controller] Data wipe unit tests Feb 28, 2025
@AleksZimin AleksZimin merged commit 5bf6fc7 into main Feb 28, 2025
11 checks passed
@AleksZimin AleksZimin deleted the data-wipe-unit-tests branch February 28, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kneumoin kneumoin kneumoin left review comments

@astef astef astef approved these changes

@AleksZimin AleksZimin AleksZimin approved these changes

Assignees

@asergunov asergunov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asergunov @astef @kneumoin @AleksZimin