[controller] Limit the length of label values for BlockDevice resources to 63 symbols
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astef
approved these changes
Dec 5, 2024
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
BlockDevice resources to 63 symbols
astef
pushed a commit
that referenced
this pull request
Feb 13, 2025
…rces to 63 symbols (#107) Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com> Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com> Co-authored-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com> Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR limits the length of label values for
BlockDeviceresources to 63 symbols. If a label value exceeds this limit, it is truncated to comply with Kubernetes restrictions, as Kubernetes does not allow label values longer than 63 characters.Why do we need it, and what problem does it solve?
Kubernetes enforces a strict 63-character limit for label values. Without this change,
BlockDeviceresources with label values exceeding this limit could cause errors during resource creation or updates. By truncating values, this fix ensures compliance and prevents such errors.What is the expected result?
BlockDeviceresources are truncated to 63 characters if they exceed the limit.BlockDeviceresources, even when original label values are longer than 63 characters.Checklist