Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Fix possible labels miss #101

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

duckhawk
Copy link
Member

@duckhawk duckhawk commented Oct 3, 2024

Description

There can be situation while LvmVolumeGroup migration when labels is missing, so hook will be failed

Why do we need it, and what problem does it solve?

This PR fixes this situation.

What is the expected result?

Working migration hook.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
@duckhawk duckhawk added the bug Something isn't working label Oct 3, 2024
@duckhawk duckhawk requested a review from AleksZimin October 3, 2024 13:57
@duckhawk duckhawk self-assigned this Oct 3, 2024
@AleksZimin AleksZimin merged commit a52f1f4 into main Oct 3, 2024
9 of 10 checks passed
@AleksZimin AleksZimin deleted the fix-possible-labels-miss branch October 3, 2024 14:34
astef pushed a commit that referenced this pull request Feb 13, 2025
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants