Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] LVMLogicalVolumeSnapshots #100

Merged
merged 57 commits into from
Dec 5, 2024
Merged

Conversation

astef
Copy link
Member

@astef astef commented Oct 2, 2024

Description

Refactoring

  • split different controllers into packages
  • make controllers structs and put external services there
  • make controllers functions/methods private
  • move hard-coded test data into a file, and embed it
  • rename some "Run*" methods to "New*" functions, since they are not running, but creating things
  • resource reconcilation code no longer depends on "sigs.k8s.io/controller-runtime/pkg/*" packages, it will be easy to migrate to a newer version of it
  • block device reconciler is now called "discoverer", to comply with existing naming strategy
  • extracted "resource clients" - kubectl client methods, which are used in different places
  • constants are separated (LLV used "Failed" status from LVG sometimes)

Bugfix

  • call to UpdateLVGConditionIfNeeded used old "Success" condition string, fixed to "Applied"
  • GetAPIBlockDevices was called from different controllers, but generated logs with the same, invalid controller name
  • LVG status.thinPools[*].usedSize in reported 100x more space used then it really was

Enhancement

  • added LVMLogicalVolumeSnapshot reconciler, which creates/deletes snapshot volumes
  • updated LLV reconciler to handle "clones" and "restores" - new LLV resources with spec.source set.

Checklist

  • [x ] Documentation updated according to the changes.
  • [ x] Changes were tested in the Kubernetes cluster manually.

Alexandr Stefurishin added 26 commits October 2, 2024 09:29
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
crd
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
@astef astef added the enhancement New feature or request label Nov 6, 2024
Alexandr Stefurishin added 3 commits November 6, 2024 21:28
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
@astef astef marked this pull request as ready for review November 12, 2024 10:25
@astef astef changed the title [controll] LVMLogicalVolume Snapshots [controller] LVMLogicalVolumeSnapshots Nov 12, 2024
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Alexandr Stefurishin added 21 commits November 15, 2024 10:22
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
fix
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
fix
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
fix
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
fix
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
fix
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
…instead

Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
@AleksZimin AleksZimin merged commit db6ffba into main Dec 5, 2024
9 checks passed
@AleksZimin AleksZimin deleted the a-stefurishin-snapshots branch December 5, 2024 12:07
astef added a commit that referenced this pull request Feb 13, 2025
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Aleksandr Stefurishin <aleksandr.stefurishin@flant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants