[internal] Fix migration from CephClusterAuthentication #38
+245
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckhawk
approved these changes
Mar 4, 2025
astef
requested changes
Mar 5, 2025
| newVolumeSnapshotClass := vsClass.DeepCopy() | ||
| if newVolumeSnapshotClass.Labels == nil { | ||
| newVolumeSnapshotClass.Labels = make(map[string]string) | ||
| } |
There was a problem hiding this comment.
How about initializing newVolumeSnapshotClass.Parameters in the same way? We will be using it on line 951
|
|
||
| func getClusterConnectionByClusterID(ctx context.Context, cl client.Client, clusterID string) (*v1alpha1.CephClusterConnection, error) { | ||
| cephClusterConnectionList := &v1alpha1.CephClusterConnectionList{} | ||
| err := cl.List(ctx, cephClusterConnectionList) |
There was a problem hiding this comment.
This heavy request will be executed for each VolumeSnapshotClass. May be it's worth doing it once and then reuse the result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist