-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from old module #34
Draft
duckhawk
wants to merge
10
commits into
main
Choose a base branch
from
migrate-from-old-module
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
…tion resources Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
d3718a0
to
d62a322
Compare
astef
requested changes
Feb 23, 2025
hooks/go/070-remove-finalizers-on-module-delete/remove-finalizers-on-module-delete.go
Outdated
Show resolved
Hide resolved
hooks/go/070-remove-finalizers-on-module-delete/remove-finalizers-on-module-delete.go
Outdated
Show resolved
Hide resolved
hooks/go/060-migrate-from-ceph-csi-module/migrate-from-ceph-csi-module.go
Outdated
Show resolved
Hide resolved
astef
previously approved these changes
Feb 23, 2025
d06f961
to
97f556a
Compare
97f556a
to
d33a52c
Compare
Signed-off-by: Vasily Oleynikov <vasily.oleynikov@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements hooks to migrate from deprecated internal module ceph-csi to current module
What is the expected result?
Automatic migration from old module
Checklist