Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various proposal picker issues when there are thousands of proposals #8558

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Fixing 2 related issues in the proposal picker.

📌 Related Issues

Link your PR to an issue

Testing

Please check the associated tickets to see both use cases.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@alecslupu alecslupu added module: proposals type: fix PRs that implement a fix for a bug labels Nov 25, 2021
@alecslupu alecslupu marked this pull request as ready for review November 26, 2021 07:36
@andreslucena andreslucena changed the title Fix various Proposal picker issues Fix various proposal picker issues when there are thousands of proposals Nov 29, 2021
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @alecslupu 👍🏽 👍🏽

@andreslucena andreslucena merged commit e38160f into decidim:develop Nov 29, 2021
@andreslucena
Copy link
Member

As this is a fix, could you make a backport to v0.25-stable @alecslupu 🙏🏽?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: meetings module: proposals type: fix PRs that implement a fix for a bug
Projects
None yet
2 participants