Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GraphQL deprecated API call #8432

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

DeprecatedDSL will be removed from GraphQL-Ruby 2.0, use .to_non_null_type instead of ! and remove .activate from /home/runner/work/decidim/decidim/decidim-core/lib/decidim/core/engine.rb:89:in `block in class:Engine' (called from block in class:Engine at /home/runner/work/decidim/decidim/decidim-core/lib/decidim/core/engine.rb:89)

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

DeprecatedDSL will be removed from GraphQL-Ruby 2.0, use `.to_non_null_type` instead of `!` and remove `.activate` from /home/runner/work/decidim/decidim/decidim-core/lib/decidim/core/engine.rb:89:in `block in <class:Engine>' (called from block in <class:Engine> at /home/runner/work/decidim/decidim/decidim-core/lib/decidim/core/engine.rb:89)
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! ❤️

@leio10 leio10 merged commit 217a974 into decidim:develop Oct 25, 2021
@alecslupu alecslupu deleted the disable-graphql-deprecated-api branch October 25, 2021 08:59
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed type: enhancement target: developer-experience labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graphql-api Affects the GraphQL API in-review type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants