Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing generator webpacker issues #8427

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Fixing generator webpacker issues #8427

merged 1 commit into from
Oct 25, 2021
+16 −2

Conversation

alecslupu
Copy link
Contributor

🎩 What? Why?

Please describe your pull request.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review October 20, 2021 07:01
leio10
leio10 approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👏👏

@leio10 leio10 merged commit e2ba5c1 into decidim:develop Oct 25, 2021
@leio10
Copy link
Contributor

leio10 commented Oct 25, 2021

@alecslupu please, can you backport this PR? Thanks! ❤️

alecslupu added a commit to tremend-cofe/decidim that referenced this pull request Oct 25, 2021
@alecslupu
Fixing generator webpacker issues (decidim#8427)
f449335
@alecslupu alecslupu deleted the fix/8424 branch October 25, 2021 15:28
@leio10 leio10 mentioned this pull request Oct 26, 2021
Merged
12 tasks
alecslupu added a commit to tremend-cofe/decidim that referenced this pull request Oct 26, 2021
@alecslupu
Fixing generator webpacker issues (decidim#8427)
af0889b
@andreslucena andreslucena added type: internal PRs that aren't necessary to add to the CHANGELOG for implementers and removed target: developer-experience type: fix PRs that implement a fix for a bug labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leio10 leio10 leio10 approved these changes

@andreslucena andreslucena Awaiting requested review from andreslucena

Assignees
No one assigned
Labels
in-review module: generators type: internal PRs that aren't necessary to add to the CHANGELOG for implementers
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

Component Generator is referencing invalid paths
3 participants
@alecslupu @leio10 @andreslucena