Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix details on conference speakers: affiliation order, personal URL link, seeds and more info link #8378

Merged
merged 4 commits into from
Oct 5, 2021

Conversation

andreslucena
Copy link
Member

@andreslucena andreslucena commented Oct 5, 2021

🎩 What? Why?

As we were configuring conference speakers for Decidim Fest 2021 on Metadecidim, a couple of bugs were detected:

  1. affiliation was hidden after the hover, so it wasn't visible
  2. in the personal URL there were two "external link" icons: one that was from the speakers' first iteration and another one introduced by the (relatively) new automatic "external link icon"
  3. when there isn't any participant account associated, the "more info" link isn't visible
  4. while working on this, I've also seen that there was a problem with seeds: they were too long and didn't reflect the real use cases that we were seeing.

This PR fixes all of this.

📌 Related Issues

Link your PR to an issue

Testing

Go to conference speakers, the new fixes should be visible
See screenshots to see how it should be seen

📷 Screenshots

1. Affiliation after hover

Before

image

image

After

image

image

2. Personal URL icon

Before

image

After

image

3. Seeds

Before

image

After

image

4. More info link

Before

image

After

image

♥️ Thank you!

@andreslucena andreslucena marked this pull request as draft October 5, 2021 07:39
@andreslucena andreslucena force-pushed the fix/conference_speakers_affiliation branch from ec37344 to 9da31af Compare October 5, 2021 08:20
@andreslucena andreslucena marked this pull request as ready for review October 5, 2021 08:55
@andreslucena andreslucena changed the title Fix details on conference speakers: affiliation order, personal URL link and seeds Fix details on conference speakers: affiliation order, personal URL link, seeds and more info link Oct 5, 2021
@leio10 leio10 merged commit 1847626 into develop Oct 5, 2021
@leio10 leio10 deleted the fix/conference_speakers_affiliation branch October 5, 2021 10:47
andreslucena added a commit that referenced this pull request Oct 5, 2021
…ink, seeds and more info link (#8378)

* Reorder affiliation in conference speakers

* Show 'more info' link always in conference speakers

* Remove personal URL extra icon in conference speakers

* Fix conference speaker affiliation seed length
andreslucena added a commit that referenced this pull request Oct 5, 2021
…ink, seeds and more info link (#8378)

* Reorder affiliation in conference speakers

* Show 'more info' link always in conference speakers

* Remove personal URL extra icon in conference speakers

* Fix conference speaker affiliation seed length
@andreslucena andreslucena added type: fix PRs that implement a fix for a bug and removed type: enhancement labels Jan 10, 2022
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: conferences type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants