Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Fix "last comment by" when commenter is a user group" #8337

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Backport "Fix "last comment by" when commenter is a user group" #8337

merged 1 commit into from
Sep 16, 2021

Conversation

leio10
Copy link
Contributor

@leio10 leio10 commented Sep 16, 2021

🎩 What? Why?

Backports #8279 to the release 0.25

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@andreslucena @cf17jeremy @leio10
Fix "last comment by" when commenter is a user group (#8279)
b44eea2 
* fixed

* Apply feedback from @leio10 and refactor last_comment_by in debates

* Add spec for last_comment_by when it's a user group

Co-authored-by: cf17jeremy <cf17jeremy.torres@iesjoandaustria.org>
@leio10 leio10 added backport Pull Requests that are a backport for a fixed bug module: debates type: fix PRs that implement a fix for a bug in-review labels Sep 16, 2021
@leio10 leio10 merged commit 40e298e into release/0.25-stable Sep 16, 2021
@leio10 leio10 deleted the backport/8279 branch September 16, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Pull Requests that are a backport for a fixed bug in-review module: debates type: fix PRs that implement a fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leio10 @andreslucena