Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Fix live? missing method delegation in online_meeting cell" to v0.25 #8309

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

entantoencuanto
Copy link
Contributor

🎩 What? Why?

Backport of PR #8241 on 0.25-stable release

📌 Related Issues

Link your PR to an issue

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

live? method is no longer available in model, so delegation fails and
the method must be defined in the cell
@andreslucena andreslucena changed the title Backport/8241 to 0.25 Backport "Fix live? missing method delegation in online_meeting cell" to v0.25 Sep 8, 2021
@leio10 leio10 added module: meetings type: fix PRs that implement a fix for a bug backport Pull Requests that are a backport for a fixed bug labels Sep 8, 2021
@leio10 leio10 merged commit 4fc07d6 into release/0.25-stable Sep 8, 2021
@leio10 leio10 deleted the backport/8241-to-0.25 branch September 8, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Pull Requests that are a backport for a fixed bug module: meetings type: fix PRs that implement a fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants