-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable default order for proposals #8295
Merged
leio10
merged 16 commits into
decidim:develop
from
mainio:feature/configurable_order_for_proposals
Sep 16, 2021
Merged
Configurable default order for proposals #8295
leio10
merged 16 commits into
decidim:develop
from
mainio:feature/configurable_order_for_proposals
Sep 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahukkanen
reviewed
Sep 3, 2021
decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb
Outdated
Show resolved
Hide resolved
ahukkanen
reviewed
Sep 3, 2021
decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb
Outdated
Show resolved
Hide resolved
ahukkanen
reviewed
Sep 3, 2021
decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb
Outdated
Show resolved
Hide resolved
ahukkanen
reviewed
Sep 3, 2021
decidim-proposals/app/controllers/concerns/decidim/proposals/orderable.rb
Outdated
Show resolved
Hide resolved
This is ready for review and can be tested here: |
leio10
added
module: proposals
type: feature
PRs or issues that implement a new feature
labels
Sep 10, 2021
I forgot to answer on this one, sorry. I've reviewed this! It works as defined in Metadecidim, thanks for the PR! |
Ready to be reviewed by you @leio10 |
leio10
approved these changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add a setting to the proposal component that specifies the default order of the proposals. Admin can also set different default order for each phase.
📌 Related Issues
https://meta.decidim.org/processes/roadmap/f/122/proposals/13104
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/
.📷 Screenshots