Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable default order for proposals #8295

Merged

Conversation

lahdeero
Copy link
Contributor

@lahdeero lahdeero commented Sep 3, 2021

🎩 What? Why?

Add a setting to the proposal component that specifies the default order of the proposals. Admin can also set different default order for each phase.

📌 Related Issues

https://meta.decidim.org/processes/roadmap/f/122/proposals/13104

Testing

  1. Login as admin -> Admin Dashboard -> Edit component
  2. Change "Default proposal sorting" to something else than default. (If you want test "most endorsed" for example, make sure you have endorsements enabled).
  3. Go to proposals index view and check "Order proposals by"

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

image

image

♥️ Thank you!

@ahukkanen
Copy link
Contributor

This is ready for review and can be tested here:
https://pr8295.decidimqa.mainiotech.fi/

@leio10 leio10 added module: proposals type: feature PRs or issues that implement a new feature labels Sep 10, 2021
@andreslucena
Copy link
Member

I forgot to answer on this one, sorry. I've reviewed this! It works as defined in Metadecidim, thanks for the PR!

@andreslucena
Copy link
Member

Ready to be reviewed by you @leio10

Copy link
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@leio10 leio10 merged commit 042d229 into decidim:develop Sep 16, 2021
@ahukkanen ahukkanen deleted the feature/configurable_order_for_proposals branch September 16, 2021 18:38
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-review module: admin module: proposals type: feature PRs or issues that implement a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants