-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception in Initiatives' Page #10928
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreslucena
added
module: initiatives
type: fix
PRs that implement a fix for a bug
labels
May 30, 2023
andreslucena
changed the title
Add spec for checking that the Page inside of an Initiative works
Fix exception in Initiatives' Page
May 30, 2023
alecslupu
reviewed
Jun 2, 2023
alecslupu
requested changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andreslucena can you have a look, on why this command is not being load up?
alecslupu
requested changes
Jun 6, 2023
Suggested on code review Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
alecslupu
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
There's a bug on the creation of Initiatives related to the Page functionality
Steps to reproduce
show.html.erb
)Explanation
This is related to the introduction of
Decidim::Env
with #8725: we're passing a string for theDecidim::initiatives.default_components
, where we used to have a symbol.decidim/decidim-generators/lib/decidim/generators/app_templates/secrets.yml.erb
Line 78 in b510d94
Mind that some installations didn't make the change to using the configuration with EnvVars, that's why its working there (for instance in https://try.decidim.org)
This PR fixes this bug in three different ways:
bin/rails decidim:initiatives:upgrade:fix_broken_pages
📌 Related Issues
Testing
Rake task
bin/rails decidim:initiatives:upgrade:fix_broken_pages
Note that it seems like the design is broken, but that's actually unrelated to the fix. It's because we have the redesign implemented on develop in
decidim-pages
New initiatives
Seeded initiatives
Regenerate the database and check that it is working by going to the "Page" of an Initiative
bin/rails db:drop db:setup db:seed
📷 Screenshots