Add the attribute to external links (#12832)

* Add the attribute to external links * Change the header value to * Indicate the canonical URL for the page * Add the rel attribute to the profile external link Co-authored-by: Antti Hukkanen <antti.hukkanen@mainiotech.fi>
decidim · May 6, 2024 · 3554ab4 · 3554ab4
1 parent 071d337
commit 3554ab4
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/decidim-core/app/cells/decidim/profile/details.erb b/decidim-core/app/cells/decidim/profile/details.erb
@@ -9,7 +9,7 @@
         <%= icon detail[:icon] %>
         <span>
           <% if detail[:url].present? %>
-            <%= link_to(detail[:url], detail[:text]) %>
+            <%= link_to(detail[:url], detail[:text], rel: "nofollow noopener noreferrer") %>
           <% else %>
             <%= detail[:text] %>
           <% end %>

diff --git a/decidim-core/app/controllers/decidim/links_controller.rb b/decidim-core/app/controllers/decidim/links_controller.rb
@@ -14,7 +14,8 @@ class LinksController < Decidim::ApplicationController
     rescue_from URI::InvalidURIError, with: :modal
 
     def new
-      headers["X-Robots-Tag"] = "noindex"
+      headers["X-Robots-Tag"] = "none"
+      headers["Link"] = %(<#{url_for}>; rel="canonical")
     end
 
     private

diff --git a/decidim-core/app/views/decidim/links/_modal.html.erb b/decidim-core/app/views/decidim/links/_modal.html.erb
@@ -16,6 +16,6 @@
     <button class="button button__lg button__transparent-secondary" data-dialog-close="external-domain-warning">
       <%= t("decidim.links.warning.cancel") %>
     </button>
-    <%= link_to t("decidim.links.warning.proceed"), external_url.to_s , target: "_blank", class: "button button__lg button__secondary" %>
+    <%= link_to t("decidim.links.warning.proceed"), external_url.to_s , target: "_blank", class: "button button__lg button__secondary", rel: "nofollow noopener noreferrer" %>
   </div>
 <% end %>
diff --git a/decidim-core/app/views/decidim/links/new.html.erb b/decidim-core/app/views/decidim/links/new.html.erb
@@ -12,7 +12,7 @@
   </code>
 
   <div class="form__wrapper-block">
-    <%= link_to t("decidim.links.warning.proceed"), external_url.to_s, class: "button button__lg button__secondary ml-auto" %>
+    <%= link_to t("decidim.links.warning.proceed"), external_url.to_s, class: "button button__lg button__secondary ml-auto", rel: "nofollow noopener noreferrer" %>
   </div>
 
 <% end %>